Skip to content

feat: commands for cli actions#479

Merged
james-elicx merged 27 commits intomainfrom
james/commands-2
Mar 21, 2025
Merged

feat: commands for cli actions#479
james-elicx merged 27 commits intomainfrom
james/commands-2

Conversation

@james-elicx
Copy link
Copy Markdown
Collaborator

@james-elicx james-elicx commented Mar 20, 2025 •
edited
Loading

  • Adds commands to use with the CLI
  • Moves the OpenNext initialisation to be run at the root of the CLI
  • Migrates e2es to use commands

This is part 3 of 3 in a stack made with GitButler:

james-elicx and others added 15 commits March 13, 2025 21:12
This was referenced Mar 20, 2025
Merged
Merged
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 20, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a147d77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 20, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@479

commit: a147d77

james-elicx
james-elicx commented Mar 20, 2025
View reviewed changes
Comment thread packages/cloudflare/src/cli/deploy/deploy.ts Outdated
@james-elicx james-elicx force-pushed the james/commands-2 branch 2 times, most recently from 0f9964c to 40e86f1 Compare March 20, 2025 15:20
@james-elicx james-elicx marked this pull request as ready for review March 20, 2025 15:56
conico974
conico974 reviewed Mar 20, 2025
View reviewed changes
Comment thread packages/cloudflare/src/cli/deploy/deploy.ts
Base automatically changed from james/r2 to main March 21, 2025 11:06
@james-elicx james-elicx requested a review from conico974 March 21, 2025 11:48
vicb
vicb reviewed Mar 21, 2025
View reviewed changes
Comment thread examples/e2e/app-router/wrangler.jsonc Outdated
vicb
vicb reviewed Mar 21, 2025
View reviewed changes
Comment thread packages/cloudflare/src/cli/args.ts
conico974
conico974 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a small question.

Comment thread packages/cloudflare/src/cli/populate-cache/populate-cache.ts
james-elicx
james-elicx commented Mar 21, 2025
View reviewed changes
Comment thread examples/e2e/app-router/wrangler.jsonc Outdated
@james-elicx james-elicx merged commit 0c93e8b into main Mar 21, 2025
7 checks passed
@james-elicx james-elicx deleted the james/commands-2 branch March 21, 2025 14:23
@workers-frameworks workers-frameworks mentioned this pull request Mar 21, 2025
Merged
@chrox
Copy link
Copy Markdown

chrox commented Mar 26, 2025 •
edited
Loading

@james-elicx The new commands for cli is great but there is no documentation for the breaking change. Following the documentation here it will shot just your feet with:

npm install --save-dev @opennextjs/cloudflare@latest

and

"deploy": "opennextjs-cloudflare && wrangler deploy"

And error log in Cloudflare worker shows:

23:00:16.820 | Success: Build command completed
-- | --
23:00:16.822 | Executing user deploy command: NODE_OPTIONS="--max-old-space-size=8192" npm run deploy
23:00:17.310 |  
23:00:17.310 | > @readest/[email protected] deploy
23:00:17.310 | > NEXT_PUBLIC_APP_PLATFORM=web opennextjs-cloudflare && wrangler deploy
23:00:17.310 |  
23:00:17.899 | file:///opt/buildhome/repo/node_modules/.pnpm/@[email protected][email protected]/node_modules/@opennextjs/cloudflare/dist/cli/args.js:47
23:00:17.900 | throw new Error("Error: invalid command, expected 'build' \| 'preview' \| 'deploy' \| 'populateCache'");
23:00:17.900 | ^
23:00:17.900 |  
23:00:17.900 | Error: Error: invalid command, expected 'build' \| 'preview' \| 'deploy' \| 'populateCache'
23:00:17.900 | at getArgs (file:///opt/buildhome/repo/node_modules/.pnpm/@[email protected][email protected]/node_modules/@opennextjs/cloudflare/dist/cli/args.js:47:19)
23:00:17.900 | at file:///opt/buildhome/repo/node_modules/.pnpm/@[email protected][email protected]/node_modules/@opennextjs/cloudflare/dist/cli/index.js:40:18
23:00:17.900 | at ModuleJob.run (node:internal/modules/esm/module_job:262:25)
23:00:17.900 | at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:483:26)
23:00:17.901 | at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5)

@chrox
Copy link
Copy Markdown

chrox commented Mar 26, 2025

OK. I found the solution in the readme file: https://github.com/opennextjs/opennextjs-cloudflare/pull/479/files#diff-be36604f10bbd9205e3930ca4cdb26388354a780fe7a8407735067cbff7694ec

The deploy script now should be:

"deploy": "opennextjs-cloudflare build && wrangler deploy"

@james-elicx
Copy link
Copy Markdown
Collaborator Author

james-elicx commented Mar 26, 2025

Hi @chrox, sorry for the delay between when this release shipped and when the docs PR was merged - it was updated shortly after your comment was left here.

@chrox
Copy link
Copy Markdown

chrox commented Mar 27, 2025

I appreciate the update! Thanks for getting the docs merged and for following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb approved these changes

@conico974 conico974 conico974 approved these changes

@dario-piotrowicz dario-piotrowicz Awaiting requested review from dario-piotrowicz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@james-elicx @chrox @vicb @conico974